Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AutoTest form with question editor and data types #2607

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

valerydluski
Copy link
Contributor

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

Describe the source of requirement, like related issue link.

💡 Background and solution

Describe the big picture of your changes here

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

Copy link

github-actions bot commented Feb 17, 2025

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/admin/auto-test-task/[taskId] 423.96 KB 500.15 KB 100.03% (🟡 +1.83%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@valerydluski
Copy link
Contributor Author

Suggested Improvements:

  1. Separate Question Card Sections: The question card should be divided into two sections—one for settings related to the question and another for settings related to the answers. This will improve clarity and organization.
  2. Unique Question ID in the Form: Currently, the question itself is used as the ID in the form, which does not guarantee uniqueness. It’s necessary to determine a better approach for generating a unique and stable ID. Possible solutions could include using a UUID, an incrementing index, or a hash of the question content.

@valerydluski valerydluski marked this pull request as draft February 22, 2025 11:05
@valerydluski
Copy link
Contributor Author

Validate Image Response URLs: Currently, there is no validation ensuring that answers of type image contain valid URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant